[refactor] stringutil catch-all file split + sanitizer dedup note

[github-actions]

🔧 Semantic Function Clustering Analysis

Analysis of github/gh-aw — scope: pkg/stringutil, pkg/styles (10 non-test .go files)

Executive Summary

Both packages are, overall, cleanly feature-organized. Scope covered 10 files / ~35 functions. No exact duplicates and no misplaced cross-domain functions (e.g. no parser logic in a network file) were found. Two low/medium-impact organizational opportunities surfaced and are detailed below. Everything else clusters correctly and is left as-is.

Function Inventory

By file / cluster

pkg/stringutil

• ansi.go — StripANSI, skipEscapeSequence, skipCSISequence, skipOSCSequence, isFinalCSIChar, isCSIParameterChar (cohesive ANSI cluster)
• fuzzy_match.go — FindClosestMatches, LevenshteinDistance (cohesive)
• identifiers.go — NormalizeWorkflowName, NormalizeSafeOutputIdentifier, MarkdownToLockFile, LockFileToMarkdown (cohesive)
• pat_validation.go — PATType + methods, ClassifyPAT, ValidateCopilotPAT, GetPATTypeDescription (cohesive)
• sanitize.go — SanitizeName, SanitizeErrorMessage, SanitizeIdentifierName, SanitizeParameterName, SanitizePythonVariableName, SanitizeToolID, SanitizeForFilename + helpers
• urls.go — NormalizeGitHubHostURL, ExtractDomainFromURL, extractDomainFallback (cohesive)
• stringutil.go — Truncate, NormalizeWhitespace, ParseVersionValue, FormatList, NormalizeLeadingWhitespace, IsPositiveInteger (grab-bag)

pkg/styles

• theme.go / theme_wasm.go — build-tag pair (real vs Wasm no-op); intentional pattern
• huh_theme.go — huh form theme mapping; correctly shares the color* palette vars with theme.go

Identified Issues

1. stringutil.go is a catch-all file (medium)

• File: pkg/stringutil/stringutil.go
• Issue: Unlike its six siblings (each named after one feature), this file bundles unrelated concerns: whitespace normalization (NormalizeWhitespace, NormalizeLeadingWhitespace), truncation (Truncate), version stringifying (ParseVersionValue), list formatting (FormatList), and integer validation (IsPositiveInteger). This breaks the package's own one-file-per-feature convention.
• Recommendation: Extract the two whitespace functions into whitespace.go (they form a clear cluster). The remaining small, genuinely-generic helpers (Truncate, FormatList, ParseVersionValue, IsPositiveInteger) can stay in stringutil.go as the residual utility file. No signature or behavior changes — pure file moves.
• Impact: Better discoverability; brings this file in line with the rest of the package. Low risk (same package, no API change).

2. Two parallel rune-mapping sanitizers (low)

• Occurrence 1: sanitize.go:223 SanitizeIdentifierName(name, extraAllowed) — strings.Map, allows [A-Za-z0-9_] + extraAllowed, replaces disallowed with _, prepends _ if leading digit.
• Occurrence 2: sanitize.go:325 SanitizeForFilename(slug) — strings.Builder loop, allows [A-Za-z0-9-_.], replaces disallowed with -.
• Similarity: Same underlying shape (rune-by-rune, isASCIIAlphanumeric gate, replace-disallowed). They differ only in the allow-set, the replacement char, and the leading-digit rule.
• Recommendation: Optional. A shared private helper mapRunes(s string, allow func(rune) bool, replacement rune) string would let SanitizeForFilename reuse the same core as SanitizeIdentifierName. Given the semantic differences (hyphen vs underscore output, leading-digit handling), this is a judgment call — only worth it if a third rune-mapping sanitizer appears. Flagged for awareness, not urgent.
• Impact: Marginal dedup; do not do preemptively.

Not Issues (verified, left alone)

• theme.go and theme_wasm.go duplicated var lists — intentional build-tag no-op stubs, not a refactor target.
• huh_theme.go re-deriving colors — already sourced from the shared color* vars; single source of truth is intact.
• SanitizeParameterName / SanitizePythonVariableName — thin, well-named wrappers over SanitizeIdentifierName; idiomatic, keep.

Recommendations

1. Priority 1 — Split whitespace helpers out of stringutil.go into whitespace.go (finding 1). ~30 min, mechanical.
2. Priority 3 — Revisit sanitizer consolidation (finding 2) only when/if a third similar sanitizer lands.

Analysis Metadata

• Files analyzed: 10 (test files excluded)
• Functions cataloged: ~35
• Clusters: 9 (7 cohesive, 1 grab-bag, 1 build-tag pair)
• Outliers: 1 file (catch-all)
• Exact duplicates: 0
• Near-duplicates: 1 pair (low significance)
• Method: per-file symbol inventory + naming/purpose clustering

Generated by 🔧 Semantic Function Refactoring · sonnet46 · 197.1 AIC · ⌖ 9.95 AIC · ⊞ 9.7K · ◷

• expires on Jul 31, 2026, 7:30 PM UTC-08:00

[github-actions]

🍪 Issue Monster selected this for Copilot

I have identified this issue as a good candidate for automated resolution and requested assignment to the Copilot coding agent.

If assignment succeeds, the Copilot coding agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

🍪 Om nom nom by Issue Monster · gpt54 · 3.9 AIC · ⌖ 5.69 AIC · ⊞ 6.4K · ◷