Add ability to specify median and mean lines for diurnal plots - #232
Open
Tom-Kingstone wants to merge 2 commits into
Open
Add ability to specify median and mean lines for diurnal plots#232Tom-Kingstone wants to merge 2 commits into
Tom-Kingstone wants to merge 2 commits into
Conversation
jamesramsden-bh
requested changes
Jul 30, 2026
jamesramsden-bh
left a comment
jamesramsden-bh
left a comment
Contributor
There was a problem hiding this comment.
On lines 137-138, you redefine mean and median, which then confuses lines 194 and 204. Consequently, I got an error when I ran a diurnal plot, where you attempt to get a true/false of a series object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #230
see linked issue
Added ability to remove the mean or median line.
Also added explicit quantile_range argument so it is clearer that that is possible from the method signature
Test files
Changelog
Additional comments