fix sorting replacement in single-sort mode - #6431
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthrough
ChangesRow sorting toggle behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 06353c5
☁️ Nx Cloud last updated this comment at |
KevinVandy
marked this pull request as ready for review
July 30, 2026 22:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
toggleSorting(..., false)previously kept the other sorted columns when the target column was already the final entry. The action was classified as a toggle, and the toggle path mapped over the entire previous state.Single-sort actions should leave at most the selected column in the sorting state, regardless of its prior position.
Validation
packages/table-core/tests/unit/features/row-sorting/rowSortingFeature.utils.test.ts— 47 tests passedgit diff --checkCloses #4309
Summary by CodeRabbit
Bug Fixes
Tests