USPR-13771: bump forced netty version to 4.2.16.Final for GHSA-4mp9-239f-g9hg - #384
Open
midnight-clue[bot] wants to merge 2 commits into
Open
USPR-13771: bump forced netty version to 4.2.16.Final for GHSA-4mp9-239f-g9hg#384midnight-clue[bot] wants to merge 2 commits into
midnight-clue[bot] wants to merge 2 commits into
Conversation
…39f-g9hg Co-Authored-By: Catarina Correia <catarina.correia@getyourguide.com>
Co-Authored-By: Catarina Correia <catarina.correia@getyourguide.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
GitHub Dependabot alert #110 flags
io.netty:netty-codec-httpversions 4.2.0.Final-4.2.15.Final as vulnerable to a WebSocket handshaker validation issue (GHSA-4mp9-239f-g9hg: WebSockets V07/V08 handshaker missing Connection/Upgrade header validation). The repo's existingresolutionStrategy.eachDependencyoverride inbuild.gradleforcedio.nettydependencies to4.2.15.Final, which is itself the last vulnerable version in this range. See USPR-13771.Solution
Bumped the existing
io.nettyversion-forcing rule inbuild.gradle'ssubprojects{}block: the comparison threshold anduseVersioncall now target4.2.16.Finalinstead of4.2.15.Final, and thebecause(...)comment now also referencesGHSA-4mp9-239f-g9hgalongside the previously-listed GHSA IDs. This is a minimal, targeted change to the existing constraint, consistent with how prior GHSA fixes were applied to this same block — no new override or BOM bump was introduced.Verification
io.netty:netty-codec-httpresolves to >= 4.2.16.Final (verified via./gradlew :spring-boot-starter:spring-boot-starter-webflux:dependencies --configuration compileClasspath, confirmed resolved version 4.2.16.Final)./gradlew test— BUILD SUCCESSFUL)🔍 Braintrust trace