USPR-13767: bump forced io.netty version to 4.2.16.Final - #390
Open
midnight-clue[bot] wants to merge 1 commit into
Open
USPR-13767: bump forced io.netty version to 4.2.16.Final#390midnight-clue[bot] wants to merge 1 commit into
midnight-clue[bot] wants to merge 1 commit into
Conversation
Resolves GHSA-gcjf-9mgh-3p7g (CRLF Injection via Multipart Filename in Netty HttpPostRequestEncoder), reported as GitHub Dependabot alert #114. Co-Authored-By: Catarina Pinheiro Correia <catarina.correia@getyourguide.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem
GitHub Dependabot flagged a moderate-severity CRLF injection vulnerability, GHSA-gcjf-9mgh-3p7g, in
io.netty:netty-codec-http(CRLF Injection via Multipart Filename in NettyHttpPostRequestEncoder), affecting versions >=4.2.0.Final and <4.2.16.Final. This was reported as GitHub Dependabot alert #114. The repo already pins Netty via aresolutionStrategyoverride to4.2.15.Finalfor prior CVEs, so it needs bumping to the patched4.2.16.Final. See USPR-13767.Solution
io.nettyversion threshold/forced version in the rootbuild.gradle'sresolutionStrategy.eachDependencyblock from4.2.15.Finalto4.2.16.Final, and appended GHSA-gcjf-9mgh-3p7g to the existingbecausereason string alongside the prior CVE list.ext['netty.version']from4.2.15.Finalto4.2.16.Finalin the two example Spring Boot projects (examples/example-spring-boot-starter-webandexamples/example-spring-boot-starter-webflux). This was necessary because Spring Boot's dependency management BOM uses thisextproperty as the authoritative constraint for Netty in those projects — the rootresolutionStrategy.eachDependencyblock alone did not change the effective resolved version there, as verified below. This follows the exact same pattern established in the prior Netty-pinning commit (850a009 / PR USPR-13707: Security Fix [USPR-13684..13707]: Bump Netty to 4.2.15.Final, Jackson to 2.21.5/3.1.4, Logback to 1.5.34 #379), which updated both mechanisms together.Verification
io.nettydependencies forced to >= 4.2.16.Final (verified via./gradlew :examples:example-spring-boot-starter-webflux:dependencies --configuration runtimeClasspath | grep -i netty-codec-http, which now showsio.netty:netty-codec-http:4.2.12.Final -> 4.2.16.Final (c)and the same fornetty-codec-http2/netty-codec-http3)becausereason string updated to document GHSA-gcjf-9mgh-3p7g alongside prior Netty CVEs🔍 Braintrust trace