Python: Use fastTC explicitly in localFlow - #22249
Open
MathiasVP wants to merge 1 commit into
Open
Conversation
…optimizer to always do this transformation.
Contributor
There was a problem hiding this comment.
Pull request overview
Explicitly uses fastTC for Python local data-flow transitive closure to avoid compiler-dependent performance regressions.
Changes:
- Adds a private
localFlowStepPluspredicate usingfastTC. - Updates
localFlowto include reflexive flow explicitly.
Show a summary per file
| File | Description |
|---|---|
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowUtil.qll |
Implements explicit fast transitive closure for local flow. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft hit a performance problem on an internal query. The root-cause was that the compiler suddenly decided not to compile a
localFlowStep*to afastTC, but instead to good old QL recursion (with a suboptimal bound on the sink as a cherry on top). This resulted in:This PR explicitly uses
fastTCto prevent this surprise from biting us all going forward.We could of course fine-tune the calls to
localFlowand ensure that the end-points are optimally bound, but we might as well follow what other languages have done in similar situations (see C#, C++, and Java).DCA looks fantastic 🎉