Actions: Improve clobbering query message and documentation - #22251
Open
JarLob wants to merge 1 commit into
Open
Actions: Improve clobbering query message and documentation#22251JarLob wants to merge 1 commit into
JarLob wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves output-clobbering alerts by identifying the affected GitHub Actions command channel and adding remediation guidance.
Changes:
- Adds channel-specific alert messages and sink labels.
- Adds query documentation with vulnerable and corrected examples.
- Extends tests to cover modeled action sinks.
Show a summary per file
| File | Description |
|---|---|
actions/ql/src/experimental/Security/CWE-074/OutputClobberingHigh.ql |
Selects tailored messages and labels by sink type. |
actions/ql/src/experimental/Security/CWE-074/OutputClobberingHigh.md |
Adds query help and remediation examples. |
actions/ql/src/change-notes/2026-07-29-output-clobbering-messages.md |
Records the query improvement. |
actions/ql/test/query-tests/Security/CWE-074/.github/workflows/output3.yml |
Adds a modeled-action test case. |
actions/ql/test/output-clobbering.model.yml |
Defines the test sink model. |
actions/ql/test/qlpack.yml |
Loads the test data extension. |
actions/ql/test/query-tests/Security/CWE-074/OutputClobberingHigh.expected |
Updates expected alerts and paths. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish environment-file sinks from legacy workflow-command sinks
in alert messages. Add query help with remediation guidance and examples.