fix: use chunked read for extension manifest hash - #3841
Merged
mnriem merged 1 commit intoJul 30, 2026
Conversation
Replace unbounded f.read() with chunked iteration to prevent excessive memory allocation on large or corrupted manifest files. Matches the pattern used in integrations/manifest.py _sha256().
Contributor
There was a problem hiding this comment.
Pull request overview
Updates extension manifest hashing to avoid loading the entire file into memory.
Changes:
- Reads manifest data in 8 KiB chunks.
- Preserves the existing SHA-256 output format.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/__init__.py |
Implements bounded-memory manifest hashing. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace unbounded
f.read()with chunked iteration to prevent excessive memory allocation.Changes
extensions/__init__.py: Use chunked read inget_hash()matchingintegrations/manifest.pypattern