fix: improve unfocused window frame pacing - #3493
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
hajimehoshi
reviewed
Jul 28, 2026
| time.Sleep(d) | ||
| u.unfocusedSleepOverhead = time.Since(t) - d | ||
| if u.unfocusedSleepOverhead < 0 { | ||
| u.unfocusedSleepOverhead = 0 |
| if elapsed+sleepOverhead >= wait { | ||
| return 0 | ||
| } | ||
| return wait - elapsed - sleepOverhead |
Owner
There was a problem hiding this comment.
max(wait - elapsed - sleepOverhead, 0)
| if d := unfocusedSleepDuration(t2.Sub(t1), u.unfocusedSleepOverhead); d > 0 { | ||
| t := time.Now() | ||
| time.Sleep(d) | ||
| u.unfocusedSleepOverhead = time.Since(t) - d |
Owner
There was a problem hiding this comment.
I doubt this overhead really matters. Actually how much is unfocusedSleepOverhead on average? Does this really fix the issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
In
internal/ui/ui_glfw.go, extract the unfocused sleep-budget calculation used byglfwBackend.updateGameand reduce its target interval from 1/60 second to the maintainer-suggested 1/120 second, continuing to subtract time already spent rendering the frame. Keep the existing focus detection, buffer swap, andtime.Sleepwiring intact, and skip sleeping when frame work has already consumed the shorter interval. Add a desktop-scoped unit test ininternal/ui/ui_glfw_test.gofor the duration calculation so boundary behavior is deterministic without relying on wall-clock timing or a live X server.Closes #3397
What type of issue is this addressing?
What this PR does | solves