Skip to content

Update Modbus Connect icon and logo - #10712

Open
dmatscheko wants to merge 13 commits into
home-assistant:masterfrom
dmatscheko:master
Open

Update Modbus Connect icon and logo#10712
dmatscheko wants to merge 13 commits into
home-assistant:masterfrom
dmatscheko:master

Conversation

@dmatscheko

Copy link
Copy Markdown
Contributor

Proposed change

The generic modbus logo is not the integration brand logo and needs to be replaced.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes generic modbus logo was not the integration brand logo and needed to be replaced.
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website: https://github.com/dmatscheko/modbus_connect

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @dmatscheko.

But modbus_connect is an internal core component of Home Asssistant and that domain should never be used by custom integrations (and thus this change is also incorrect).

@home-assistant
home-assistant Bot marked this pull request as draft July 12, 2026 10:19
@home-assistant

Copy link
Copy Markdown

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@dmatscheko

Copy link
Copy Markdown
Contributor Author

Thanks for the review @frenck. I think this is about the new Modbus work landing in core, so let me make sure we're talking about the same thing.

The new core integration is modbus_connection, announced last week. My integration is modbus_connect - a different domain, and it predates that core work. I added the brand under custom_integrations/modbus_connect/ back in 2025, that path is by definition for custom integrations (core lives in core_integrations / core_brands), and the original icons there were drawn by me in SVG. This PR only replaces my own artwork with an updated version - it doesn't touch core.

That said, I do understand the concern about modbus_connect being close to the new modbus_connection. If that near-collision is the real blocker, I'm happy to rename my integration to something clearly distinct - just let me know and I'll sort out the brand accordingly.

If the position is instead that modbus_connect shouldn't live under custom_integrations/ at all, then the consistent step would be to remove the whole custom_integrations/modbus_connect/ folder - including the current icons, which are equally mine - rather than only blocking this icon update. Either way I'm glad to go along with whatever keeps the namespace clean; I'd just like the folder to end up in a coherent state.

@dmatscheko
dmatscheko marked this pull request as ready for review July 12, 2026 12:16
@home-assistant
home-assistant Bot requested a review from frenck July 12, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants