Update Modbus Connect icon and logo - #10712
Conversation
frenck
left a comment
There was a problem hiding this comment.
Sorry, @dmatscheko.
But modbus_connect is an internal core component of Home Asssistant and that domain should never be used by custom integrations (and thus this change is also incorrect).
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Thanks for the review @frenck. I think this is about the new Modbus work landing in core, so let me make sure we're talking about the same thing. The new core integration is That said, I do understand the concern about If the position is instead that |
Proposed change
The generic modbus logo is not the integration brand logo and needs to be replaced.
Type of change
Additional information
Checklist
icon.png)icon@2x.png)logo.png)logo@2x.png)