Fix: play sound for Missile Silo being built just like a sound is played for all buildings

[VariableVince]

Description:

When a building is constructed, they all emit a sound. Port, city, etc. Except for missile silo which are built silently.

But a sound effect was originally made by camclark when he made all the other sound effects. The sound file for silo-built is therefor actually already present in the repo.

Add this existing, original, silo-built sound effect to the sound controller.

The silo sound simply seems to have been overlooked when approving sounds in #3394.

The other unapproved files seem to actually not (yet) be approved for a reason. Like i can imagine not wanting a sound on every sam missile fired. But all other buildings emit a sound on being built, just not the missile silo and that's why it genuinly seems overlooked.

Missile Silo built created in PR 3394 already and was "Waiting for approval" but actually seems to have been overlooked for approval, as the only building where no sound is played currently:

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

tryout33

[coderabbitai]

Walkthrough

Missile silo creation now emits a new "silo-built" sound for silos owned by the current player. The sound effect union and URL map include the corresponding audio asset.

Changes

Missile silo sound

Layer / File(s)	Summary
Missile silo sound effect wiring src/client/sound/Sounds.ts, src/client/controllers/SoundEffectController.ts	Adds the "silo-built" sound type and asset URL, then emits it when the current player creates a missile silo.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: celant, developingtom, evanpelle, flopinguin

Poem

A silo rises, strong and bright,
Its launch is marked with sound and light.
One new name joins the sound array,
Then plays when builders have their day. 🚀

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly matches the main change: adding a build sound for Missile Silo construction.
Description check	✅ Passed	The description is directly related to wiring the existing silo-built sound into the sound controller.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}