test: add unit tests for _plotly_utils string helpers - #5669
Merged
emilykl merged 1 commit intoJul 30, 2026
Conversation
Cover the previously untested pure helpers in _plotly_utils/utils.py: levenshtein, find_closest_string, split_multichar, split_string_positions, display_string_positions, chomp_empty_strings, is_skipped_key, and _natural_sort_strings. Expected values come from the function docstrings and were confirmed against actual output. Follows the pattern of the recent utility test PRs.
Contributor
Author
|
Hi maintainers, friendly ping on this one. The Python CI workflows are sitting at |
Contributor
|
Thanks for the PR! Our team will review and follow up. |
emilykl
approved these changes
Jul 30, 2026
emilykl
left a comment
emilykl
left a comment
Contributor
There was a problem hiding this comment.
Thanks @DogInfantry for the contribution! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit coverage for pure string/utility helpers in
_plotly_utils/utils.pythat currently have no tests. These functions back the "did you mean" suggestions and path parsing used in validator error messages.Covered:
levenshteinfind_closest_stringsplit_multicharsplit_string_positionsdisplay_string_positionschomp_empty_stringsis_skipped_key_natural_sort_stringsNotes:
tests/test_plotly_utils/test_utils.py), following the recent utility test PRs (test: add unit tests for image_array_to_data_uri #5657, test: add unit tests for rgb/hex color conversion helpers #5659, test: add unit tests for relative_import #5663).Verification:
pytest tests/test_plotly_utils/test_utils.py-> 34 passed;ruff checkandruff format --checkclean.