[pika] Fix connection parameter for callbacks - #16106
Merged
Merged
Conversation
The callbacks provided to a connection get passed the connection as first argument. While this was correctly typed as `Self` in the base `Connection` class, the concrete `Connection` class was used in sub-classes. Fixed to use `Self` in sub-classes as well.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: zulip (https://github.com/zulip/zulip)
- zerver/lib/queue.py:286: error: Argument "on_open_error_callback" to "ExceptionFreeTornadoConnection" has incompatible type "Callable[[Connection, str | Exception], None]"; expected "Callable[[Connection, BaseException], object] | None" [arg-type]
+ zerver/lib/queue.py:286: error: Argument "on_open_error_callback" to "ExceptionFreeTornadoConnection" has incompatible type "Callable[[Connection, str | Exception], None]"; expected "Callable[[ExceptionFreeTornadoConnection, BaseException], object] | None" [arg-type]
- zerver/lib/queue.py:287: error: Argument "on_close_callback" to "ExceptionFreeTornadoConnection" has incompatible type "Callable[[Connection, Exception], None]"; expected "Callable[[Connection, BaseException], object] | None" [arg-type]
+ zerver/lib/queue.py:287: error: Argument "on_close_callback" to "ExceptionFreeTornadoConnection" has incompatible type "Callable[[Connection, Exception], None]"; expected "Callable[[ExceptionFreeTornadoConnection, BaseException], object] | None" [arg-type]
|
donbarbos
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callbacks provided to a connection get passed the connection as first argument. While this was correctly typed as
Selfin the baseConnectionclass, the concreteConnectionclass was used in sub-classes. Fixed to useSelfin sub-classes as well.