Clarify why fetching stays in the Effect in "Fetching data" - #8564
Open
deepusnath wants to merge 1 commit into
Open
Clarify why fetching stays in the Effect in "Fetching data"#8564deepusnath wants to merge 1 commit into
deepusnath wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
The "Fetching data" example keeps `page` in the Effect's dependency array while also updating it from `handleNextPageClick`, which reads as a contradiction with the page's own advice to prefer event handlers. Add a paragraph making the deciding factor explicit: fetch in the handler when a value can *only* change from that event, and synchronize in an Effect when the value can also change for other reasons (here, `page` and `query` can both come from the URL via Back/Forward). Addresses reactjs#8506 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
deepusnath
force-pushed
the
docs/clarify-fetching-data-effect
branch
from
July 30, 2026 18:10
c8760b6 to
99976e5
Compare
deepusnath
marked this pull request as draft
July 30, 2026 18:11
deepusnath
marked this pull request as ready for review
July 30, 2026 18:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Fetching data" example keeps
pagein the Effect's dependency array while also updating it fromhandleNextPageClick, which reads as a contradiction with the page's own advice to prefer event handlers.Add a paragraph making the deciding factor explicit: fetch in the handler when a value can only change from that event, and synchronize in an Effect when the value can also change for other reasons (here,
pageandquerycan both come from the URL via Back/Forward).Addresses #8506